Add given_name and family_name attributes to id token #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks fine. Ideally, we'd have a canonical list of attributes which are supposed to be exposed via the tokens and then we could write tests which verify they're exposed (if they're set on the user), but unless someone volunteers to do that I'm happy to just merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360
Adds the given_name and family_name attributes into the id token.
In our project making use of cognito-local (thanks for this) this addressed the problem for us.
Guidance would be helpful on whether this is indeed the correct fix and how the tests should be modified to prevent a future regression on these attributes (typescript not being my forte).